Re: [PATCH 03/14 v3] Input: atmel_mxt_ts - refactor mxt_read/write_reg to take a length
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2012-05-09 05:54:20
Also in:
lkml
Hi Daniel, On Wed, Apr 18, 2012 at 09:21:48PM +0800, Daniel Kurtz wrote:
+ ret = i2c_transfer(client->adapter, xfer, 2);
+ if (ret != 2) {
+ dev_err(&client->dev, "i2c read reg failed (%d)\n", ret);
+ if (ret >= 0)
+ ret = -EIO;
}
- return 0;
+ return (ret == 2) ? 0 : ret;
}
Would prefer:
ret = i2c_transfer(client->adapter, xfer, ARRAY_SIZE(xfer));
if (ret != ARRAY_SIZE(xfer)) {
if (ret >= 0)
ret = -EIO;
dev_err(&client->dev, "i2c read reg failed (%d)\n", ret);
return ret;
}
return 0;
Or maybe we need i2c_transfer_exact() wrapper? Jean?
Thanks.
--
Dmitry