Thread (9 messages) 9 messages, 6 authors, 2012-04-24

Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no

From: Jiri Kosina <hidden>
Date: 2012-04-24 08:53:06
Also in: lkml

On Sun, 22 Apr 2012, Geert Uytterhoeven wrote:
quoted
quoted
quoted
Matthew suggested that additional kernel patches were required to add a
scope parameter so upower could understand that the battery is powering
a device and not the system.

Also, when did it become OK to force-enable a new feature that is
_known_ to not work properly on recent userspace?  That makes no sense
to me.
I agree. It's a great feature, but it shouldn't be default y if
userspace isn't ready for it yet.
Fully agreed, the 'default y' part escaped my attention. I will be
applying the patch and pushing out to Linus.

I even wonder whether we shouldn't put a warning into the Kconfig entry,
explaining the consequences of having userspace not ready for the feature.
I saw it move from HID_BATTERY_STRENGTH=y to "# HID_BATTERY_STRENGTH
is not set" in my max-all build.
Good point, thanks Geert. I will fix that up.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help