Re: [RFC 1/1] HID: User-space I/O driver support for HID subsystem

Hi David,

quoted

quoted

new file mode 100644
index 0000000..1a7df0d

--- /dev/null
+++ b/include/linux/uhid.h

@@ -0,0 +1,71 @@
+#ifndef __UHID_H_
+#define __UHID_H_
+
+/*
+ * User-space I/O driver support for HID subsystem
+ * Copyright (c) 2012 David Herrmann
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation; either version 2 of the License, or (at your option)
+ * any later version.
+ */
+
+#include <linux/input.h>
+#include <linux/types.h>
+
+enum uhid_event_type {
+     UHID_CREATE,
+     UHID_DESTROY,
+     UHID_START,
+     UHID_STOP,
+     UHID_OPEN,
+     UHID_CLOSE,
+     UHID_OUTPUT,
+     UHID_OUTPUT_EV,
+     UHID_INPUT,
+};
+
+struct uhid_create_req {
+     __u8 __user name[128];
+     __u8 __user *rd_data;
+     __u16 rd_size;
+

we need the bus here as well. With HIDP it was implicit, but here it is
no longer implicit.

Uh, yeah, I will add that, thanks. I also need to find a proper way to
get a hid->dev.parent pointer.

quoted

quoted

+     __u16 vendor;
+     __u16 product;
+     __u16 version;
+     __u8 country;

What are we using country for these days?

I copied it from HIDP. If we don't need this, I can remove it. USBHID
doesn't use it as far as I can see.

in USB it is the hdesc->bCountryCode. And in Bluetooth BR/EDR it comes
from the SDP record. So it makes sense to keep it.

Regards

Marcel