Re: [PATCH] input: wacom: Use touch size for ABS_MT_TOUCH_MAJOR
flat view
From: Chris Bagwell <hidden>
Date: 2012-03-09 22:30:18
On Wed, Mar 7, 2012 at 7:39 PM, Jason Gerecke [off-list ref] wrote:
quoted hunk ↗ jump to hunk
3rd-gen Bamboo devices report both "amplitude" and "size" data in their touch packets. This patch changes the source for ABS_MT_TOUCH_MAJOR to be the latter rather than the former. --- drivers/input/tablet/wacom_wac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index d0b0fc4..5daf11d 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet/wacom_wac.c@@ -916,7 +916,7 @@ static void wacom_bpt3_touch_msg(struct wacom_wac *wacom, unsigned char *data)if (touch) { int x = (data[2] << 4) | (data[4] >> 4); int y = (data[3] << 4) | (data[4] & 0x0f); - int w = data[6]; + int w = data[5]; input_report_abs(input, ABS_MT_POSITION_X, x); input_report_abs(input, ABS_MT_POSITION_Y, y); -- 1.7.9.1
I found time to test this patch and used "mtview" so I could get some visual feedback. The lines because extremely thin with this change. Part of reason I quickly traced to we are setting range as 0-255 but I couldn't get data[5] to go above a value of 18. So I changed range to 0-16 and it works better but the lines still never gets very thick (this could well be that mtview doesn't scale values and prefers 0-255. I didn't look). Amplitude feels better to me using test apps but your in a better position to say if we should really change this. Please adjust declared range though if you still think we should change this. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html