Re: [PATCH] Input: max8925_onkey - avoid accessing input device too early
From: Haojian Zhuang <haojian.zhuang@gmail.com>
Date: 2012-03-06 08:52:03
On Tue, Mar 6, 2012 at 2:31 PM, Dmitry Torokhov [off-list ref] wrote:
Input device must be allocated (but not necessarily registered) before requesting IRQs, otherwise there is a chance that IRQ handler fires and tries to reference not yet allocated input device. Also it makes sense to store relative IRQ numbers in max8925_onkey_info structure as they are needed in suspend/resume which we expect to be called more often than probe and remove. Signed-off-by: Dmitry Torokhov <redacted> --- drivers/input/misc/max8925_onkey.c | 91 +++++++++++++++++------------------- 1 files changed, 44 insertions(+), 47 deletions(-)
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html