RE: [PATCH 4/4] Input: pxa27x_keypad add choice to set direct_key_mask
flat view
DORMANTno replies
From: Chao Xie <hidden>
Date: 2012-03-29 09:15:00
Also in:
linux-arm-kernel
Thanks. I will sent V2 patches. -----Original Message----- From: Sergei Shtylyov [mailto:sshtylyov@mvista.com] Sent: Thursday, March 29, 2012 2:04 AM To: Chao Xie Cc: linux-input@vger.kernel.org; eric.y.miao@gmail.com; Haojian Zhuang; linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] Input: pxa27x_keypad add choice to set direct_key_mask Hello. On 03/28/2012 09:08 AM, Chao Xie wrote:
Direct keys usage may not start from KP_DKIN0, add a msk option to configure the specifics for platforms that can skip some keys.
Signed-off-by: Chao Xie<redacted>
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c index b41ebda..661892b 100644 --- a/drivers/input/keyboard/pxa27x_keypad.c +++ b/drivers/input/keyboard/pxa27x_keypad.c@@ -391,7 +391,12 @@ static void pxa27x_keypad_config(struct pxa27x_keypad *keypad) if (pdata->direct_key_num> direct_key_num) direct_key_num = pdata->direct_key_num; - keypad->direct_key_mask = ((1<< direct_key_num) - 1)& ~mask; + /* Direct keys usage may not start from KP_DKIN0, check the platfrom + * msk data to config the specific */
The preferred multi-line comment style is not this one. You got it right in
the previous patch. :-)
WBR, Sergei