Re: [PATCH] hid-magicmouse: Add pointer and buttonpad properties for Magic Trackpad

On Tue, 21 Feb 2012, Chase Douglas wrote:

quoted

quoted

Signed-off-by: Chase Douglas <redacted>
---
 drivers/hid/hid-magicmouse.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index 2ab7175..7cf3ffe 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c

@@ -418,6 +418,8 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
 		__set_bit(BTN_TOOL_TRIPLETAP, input->keybit);
 		__set_bit(BTN_TOOL_QUADTAP, input->keybit);
 		__set_bit(BTN_TOUCH, input->keybit);
+		__set_bit(INPUT_PROP_POINTER, input->propbit);
+		__set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
 	}
 
 	if (report_touches) {

Applied, although a bit more verbose commit message would be welcome next 
time :)

Will you push this for 3.3, or keep it for 3.4?

As the old set of properties has been there since 2.6.37, I wasn't 
considering pushing this for 3.3 still. Do you feel otherwise?

Thanks,

-- 
Jiri Kosina
SUSE Labs