Re: [PATCH v2] bcm5974: Add pointer and buttonpad properties
From: Chase Douglas <hidden>
Date: 2012-02-14 19:00:44
On 02/14/2012 07:52 PM, Henrik Rydberg wrote:
Hi Chase, On Tue, Feb 14, 2012 at 07:26:39AM -0800, Chase Douglas wrote:quoted
In order to inform userspace of physical properties of the device. Signed-off-by: Chase Douglas <redacted> --- drivers/input/mouse/bcm5974.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index 5ec617e..9faa049 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c@@ -434,6 +434,9 @@ static void setup_events_to_report(struct input_dev *input_dev, __set_bit(BTN_LEFT, input_dev->keybit); input_set_events_per_packet(input_dev, 60); + + __set_bit(INPUT_PROP_POINTER, input->propbit); + __set_bit(INPUT_PROP_BUTTONPAD, input->propbit); } /* report button data as logical button state */-- 1.7.9Applied, with fixes. The patch did not apply, and once resolved, did not compile. I trust you will test also the trivial patches in the future.
You're right, I compiled the other modules and tested, but I forgot this one. It was a copy/paste error. Thanks for fixing it, I'd be happy to fix it up in the future if there are any issues. -- Chase