Thread (7 messages) 7 messages, 5 authors, 2012-02-14

Re: [PATCH resend] bcm5974: Add pointer and buttonpad properties

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2012-02-14 17:00:54

On Tuesday, February 14, 2012 04:28:18 PM Mohamed Ikbel Boulabiar wrote:
On Tue, Feb 14, 2012 at 4:23 PM, Chase Douglas

[off-list ref] wrote:
quoted
I can add that, it's just superfluous. It doesn't really tell the reader
anything if they need to know what is going on. Unless the message is
supposed to copy the definition of the properties themselves, which is
rather pointless.

It's like documenting a function:

bool is_object_mutable();
Returns true if object is mutable;

There's really no point.
We don't always have the message+code. In the end we have only commit
msgs like the raw changelog here :
http://www.kernel.org/pub/linux/kernel/v3.0/ChangeLog-3.2.6
The summary of the patch would still be in the changelog:

	bcm5974: Add pointer and buttonpad properties

and I rally do not see the point of trying to expand it into the body
of the changelog if there isn't anything more to say. It's the same
as checkpatch complaining that some Kconfig options are too short
when full description does indeed fit into 1 line (for example enabling
SPI or I2C support module for a certain device when driver split
into core and bus-specific parts - there is literally nothing else to
say).

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help