Thread (2 messages) 2 messages, 1 author, 2012-02-09

Re: [PATCH] synaptics enters infinite reconnect loop on resume from suspend on Vostro v13

From: Ahmet Inan <hidden>
Date: 2012-02-09 09:31:27

On Tue, Jan 31, 2012 at 1:58 PM, Ahmet Inan [off-list ref] wrote:
since linux-3.2 (had linux-2.6.38 before), when resuming from suspend,
the synaptics driver enters an infinite loop, trying to reconnect the touchpad
on my wife's Vostro v13 again and again.
now on linux-3.2.5 i get the same result without my patch, dmesg.txt attached:
..
[ 7853.780736] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7853.782423] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7854.295576] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7854.297329] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7854.810093] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7854.810102] psmouse serio1: issuing reconnect request
[ 7856.053337] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7856.055087] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7856.572024] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7856.574094] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7857.093857] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7857.093866] psmouse serio1: issuing reconnect request
[ 7858.366209] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7858.369115] psmouse serio1: TouchPad at isa0060/serio1/input0 lost
sync at byte 1
[ 7864.567915] psmouse serio1: TouchPad at isa0060/serio1/input0 -
driver resynced.

the last line in dmesg is the result of manualy disabling/enabling
that touchpad via hotkeys.

with my patch, i am not able able to trigger that problem, even after
twenty s2r cylces.

so please consider including this patch in the next revision.

Ahmet

Signed-off-by: Ahmet Inan <redacted>
---
diff -Nru linux-3.2.2.orig/drivers/input/mouse/synaptics.c
linux-3.2.2/drivers/input/mouse/synaptics.c
--- linux-3.2.2.orig/drivers/input/mouse/synaptics.c    2012-01-31
12:43:40.528791525 +0100
+++ linux-3.2.2/drivers/input/mouse/synaptics.c 2012-01-31
10:51:29.000000000 +0100
@@ -1219,6 +1219,7 @@
        int retry = 0;
        int error;

+       ssleep(1);
        do {
                psmouse_reset(psmouse);
                if (retry) {

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help