Thread (2 messages) 2 messages, 2 authors, 2012-02-10

re: Input: add Cypress TTSP capacitive multi-touch screen support

From: Dan Carpenter <hidden>
Date: 2012-02-01 09:40:50

Hello Javier Martinez Canillas,

This is a semi-automatic email about new static checker warnings.

The patch 4065d1e7b216: "Input: add Cypress TTSP capacitive 
multi-touch screen support" from Jan 31, 2012, leads to the following 
Smatch complaint:

drivers/input/touchscreen/cyttsp_core.c +526 cyttsp_probe()
	 warn: variable dereferenced before check 'dev' (see line 521)

drivers/input/touchscreen/cyttsp_core.c
   520	{
   521		const struct cyttsp_platform_data *pdata = dev->platform_data;
                                                           ^^^^^
dereference.

   522		struct cyttsp *ts;
   523		struct input_dev *input_dev;
   524		int error;
   525	
   526		if (!dev || !bus_ops || !pdata || !pdata->name || irq <= 0) {
                    ^^^^
check.

   527			error = -EINVAL;
   528			goto err_out;

"dev" is never NULL here so the check can be removed probably.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help