Thread (11 messages) 11 messages, 4 authors, 2012-02-24

Re: [PATCH] CHROMIUM: Input: synaptics - filter out the events with low z values

From: Henrik Rydberg <hidden>
Date: 2012-02-22 11:05:14
Also in: lkml

Hi Daniel,
quoted
So if num_fingers == 2 and only one of a and b returns
finger_touched() == true, we fall back to zero fingers?
Actually, yes.   In this case, we will have 2 x's and 2 y's, but not
know which belong to a good finger and which belong to a too light
finger....  sigh... synaptics... sigh...
I see the problem. However, ignoring it will just move the problem
forward to another bug report, will it not?  Hysteresis is a slam dunk
here.  In addition, since the low-pressure state is bound to be
transitional (soon to be followed by a real num_fingers==1 package),
simply skipping such packages might be a better option.
quoted
Why not introduce hysteresis for all fingers here? There is an example
implementation in bcm5974.c in the same directory.
Good idea, can it be in a different, follow-up patch?
Why should it be?

Thanks,
Henrik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help