Thread (3 messages) 3 messages, 3 authors, 2012-02-21

Re: [PATCH] HID: wacom: fix proximity tool release

From: Jiri Kosina <hidden>
Date: 2012-02-21 13:26:04
Also in: lkml

On Sun, 19 Feb 2012, Przemo Firszt wrote:
quoted hunk ↗ jump to hunk
Don't zero the current tool before reporting its release to the input
subsystem.

Signed-off-by: Aristeu Rozanski <redacted>
Tested-by: Przemo Firszt <redacted>
---
 drivers/hid/hid-wacom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index 0621047..696b907 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata,
 
 	switch (data[1]) {
 	case 0x80: /* Out of proximity report */
-		wdata->tool = 0;
 		input_report_key(input, BTN_TOUCH, 0);
 		input_report_abs(input, ABS_PRESSURE, 0);
 		input_report_key(input, wdata->tool, 0);
+		wdata->tool = 0;
 		input_sync(input);
 		break;
 	case 0xC2: /* Tool report */
I have put this into my upstream-fixes branch. I think this should go into 
3.3 still.

Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help