Hi Shubhrajyoti,

--- On Mon, 2/1/12, Shubhrajyoti <shubhrajyoti@ti.com> wrote:

quoted

+    int   

       
pressed;    /* 1 = pressed, 0 = released */
Could this be bool ?

OK.

quoted

+config MOUSE_NAVPOINT_PXA27x
+    tristate "Synaptics NavPoint

(PXA27x SSP/SPI)"

quoted

+    depends on PXA27x &&

PXA_SSP

quoted

+    help
+      This option enables support

for the Synaptics NavPoint connected to

quoted

+      a PXA27x SSP port in SPI

slave mode. The driver implements a simple

quoted

+      navigation pad. The four

raised dots are mapped to UP/DOWN/LEFT/RIGHT

quoted

+      buttons and the centre of

the touchpad is mapped to the ENTER button.
Maybe some help on module building as tristate.

OK.

quoted

+    ret = request_irq(ssp->irq,

navpoint_int, 0, pdev->name, &pdev->dev);
Could this be a threadded irq?

The reading of the SSDR could not, because that is needed to clear the
interrupt.
The initial processing of navpoint_packet() could, but would require a new FIFO between the hard irq and threaded irq handlers to buffer the 16-bit data from the SSDR. Since most of the data is ultimately discarded I can avoid the FIFO by keeping this initial processing in the hard irq handler.
The final processing of navpoint_packet(), the calls to input_report_key() and input_sync(), could and should. I presume this was your main concern.

navpoint_resume(&pdev->dev);
Could this be pushed to open instead?

It could. In practice the navpoint device would only be opened by the X server, and thus would remain open for the duration of the system anyway.
But I'm happy to add a new open function.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html