Thread (4 messages) 4 messages, 4 authors, 2012-02-01

Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver()

From: Jesse Barnes <hidden>
Date: 2012-01-27 18:40:19
Also in: linux-pci, lkml

On Tue, 24 Jan 2012 13:34:41 -0500 (EST)
Alan Stern [off-list ref] wrote:
As part of the removal of get_driver()/put_driver(), this patch
(as1511) changes all the places that add dynamic IDs for drivers.
Since these additions are done by writing to the drivers' sysfs
attribute files, and the attributes are removed when the drivers are
unregistered, there is no reason to take an extra reference to the
drivers.

The one exception is the pci-stub driver, which calls pci_add_dynid()
as part of its registration.  But again, there's no reason to take an
extra reference here, because the driver can't be unloaded while it is
being registered.
Looks fine, you can add my ack too.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help