Re: [PATCH] input: egalax_ts: optmize driver for more fluency touch feelling

Hi Zhang,

On Wed, Dec 07, 2011 at 05:10:02PM +0800, Zhang Jiejing wrote:

egalax_ts use threaded_irq to report touch event, it will wake up the
irq thread and stop the thread irq after process one touch event, so
even user touch the screen very fast, the fastest event report speed
is depends on the scheduler, so the event reported is a uniform speed.

I am not sure what you mean by "the event reported is a uniform speed"
but since I2C operations generally sleep you are at the mercy of
scheduler anyways. But since IRQ thread is a real-time one it should get
scheduled immediately.

This patch will let thread irq check the gpio's status, if the gpio
is down, means still have more events, it will not exit the irq handler
and continue process another new event, it can improve user experience.

Does it really or it is your opinion that it would?

Also, your change means that the driver can not be stopped/unloaded as
long as user had finger on the touchpad. This would need to be corrected
(but first you need to prove that the change is actually needed).

Thanks.

-- 
Dmitry