Re: [PATCH v2] Touchscreen driver for FT5x06 based EDT displays
From: Anatolij Gustschin <agust@denx.de>
Date: 2011-12-02 13:51:50
Hi Simon, there is a number of issues with this patch. Please check it using 'scripts/checkpatch.pl' and fix them before posting next patch version. Thanks! Please see a comment below. On Thu, 29 Sep 2011 17:52:57 +0200 Simon Budig [off-list ref] wrote: ...
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c new file mode 100644 index 0000000..1c4725d --- /dev/null +++ b/drivers/input/touchscreen/edt-ft5x06.c
...
+static int edt_ft5x06_i2c_ts_probe(struct i2c_client *client,
+ const struct i2c_device_id *id)
+{...
+ + dev_set_drvdata(&client->dev, tsdata); + tsdata->client = client; + pdata = client->dev.platform_data; + + tsdata->reset_pin = pdata->reset_pin;
passing platform data for specifying reset_pin should be optional, I think. There are hardware configurations without wired gpio for /RST controlling, /RST is controlled by HW-circuitry. The driver should be usable with such configurations, too. Can you please change the driver so that controlling reset pin becomes optional? Thanks, Anatolij