Re: [PATCH 1/1] hid_wiimote: add INPUT_FF_MEMLESS dependency

On Sun, Dec 25, 2011 at 5:13 PM, Alec Moskvin [off-list ref] wrote:

Hi David,

On Sunday 25 December 2011 11:06:58, David Herrmann wrote:

quoted

Hi Alec

On Sat, Dec 24, 2011 at 5:42 PM, Alec Moskvin [off-list ref] wrote:

quoted

This fixes build error:
...
CRC 17a7c33e
Kernel: arch/x86/boot/bzImage is ready  (#1)
 Building modules, stage 2.
 MODPOST 7 modules
ERROR: "input_ff_create_memless" [drivers/hid/hid-wiimote.ko]
undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Signed-off-by: Alec Moskvin <redacted>
---
 drivers/hid/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 22a4a05..332c22a 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig

@@ -620,6 +620,7 @@ config HID_WIIMOTE

       depends on BT_HIDP
       depends on LEDS_CLASS
       select POWER_SUPPLY
+       select INPUT_FF_MEMLESS
       ---help---
       Support for the Nintendo Wii Remote bluetooth device.

This fix is already in Jiri's tree. See here:
http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e

Regards
David

I wasn't aware of that. Shouldn't it be pushed to the main tree, then?

It's CC'ed to stable. I think Jiri will push it to linus soon. But
during Christmas some stuff may get lost so ping him if he missed
something ;)

It's not in 3.2-rc7 (released yesterday), which is why I reported it.

Thanks,
Alec

Cheers
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html