Thread (12 messages) 12 messages, 4 authors, 2012-03-29

Re: [PATCH 1/1] input: keyboard: Set configuration registers

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-12-09 21:25:19
Also in: linux-tegra, lkml

On Friday, December 09, 2011 12:10:43 PM Stephen Warren wrote:
Shridhar Rasal wrote at Friday, December 09, 2011 12:29 AM:
quoted
To: dmitry.torokhov@gmail.com
Cc: rydberg@euromail.se; Stephen Warren; Rakesh Iyer;
linux-kernel@vger.kernel.org; linux- input@vger.kernel.org;
linux-tegra@vger.kernel.org; Shridhar Rasal Subject: [PATCH 1/1] input:
keyboard: Set configuration registers

-Set only REQUIRED row and column configuration register to
PROPER values to avoid continuously generating KBC input events.
-Use *en* field in pin_cfg, to check GPIO_x_ROW_EN register
should be set or clear.

Signed-off-by: Shridhar Rasal <redacted>
I wondered if num==0 could be used instead of a new en field, but 0 is a
valid row/column number, so no. As such,

Acked-by: Stephen Warren <redacted>
Can we pass in number of pin_cfg instances in pdata and simply do not
mention unneeded pins instead?

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help