Thread (14 messages) flat view 14 messages, 4 authors, 2011-12-14

Re: [PATCH] edt_ts: EDT Touchscreen driver

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-11-20 18:36:20

On Sun, Nov 20, 2011 at 10:09:24PM +0400, Ilya Yanok wrote:
Hi Dmitry,

one quick question before I repost the updated patch:

On 14.11.2011 21:28, Dmitry Torokhov wrote:
quoted
quoted
+err0:
+	dev_set_drvdata(&client->dev, NULL);
Not needed.
Do you really think leaving a pointer to a non-existing structure is a
good idea?
I2C core takes care of clearing it after remove() or failed probe().

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help