Re: Build breakage in samsung-keypad driver

Hi Mark,

On Tue, Nov 15, 2011 at 12:53:20PM +0000, Mark Brown wrote:

Hi Dmitry,

Your commit 5862c02 (Input: samsung-keypad - enable compiling on other
platforms) breaks the build on any platform using the driver as you've
moved the header defining the platform data without updating any of the
users.  Whenever doing updates to platform data you really need to grep
the tree for users and make sure they're updated otherwise there will be
build breakage.

Hmm, I haven't removed the original header though, I had plat/keypad.h
include the new linux/input/samsung-keypad.h so that it should be
transparent for all existing users.

Could you tell me exactly what breaks?

I also can't see the patch on the list...

Admittedly was buried in a separate thread, but:

http://www.spinics.net/lists/linux-samsung-soc/msg06578.html

Thanks.

-- 
Dmitry