Re: [PATCH 8/8] hid-multitouch: correct eGalax a001 protocol
From: Chris Bagwell <hidden>
Date: 2011-11-23 18:20:25
Also in:
lkml
On Wed, Nov 23, 2011 at 3:54 AM, Benjamin Tissoires [off-list ref] wrote:
From: Benjamin Tissoires <redacted> This device use another protocol while sending the events. It's the same as the one described as "serial" by Microsoft. We are keeping here the sn_move and sn_pressure parameters for egalax devices. CC: Cedric Sodhi <redacted> CC: Chris Bagwell <redacted> Signed-off-by: Benjamin Tissoires <redacted> ---
Thanks for sending this patch. If you like, you can add this for all the patches except #2. I'm not the best for reviewing sysfs code. Reviewed-by: Chris Bagwell <redacted> 3-5 are nice cleanups to have. Chris
quoted hunk ↗ jump to hunk
drivers/hid/hid-multitouch.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 77210d6..f0f3632 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c@@ -97,6 +97,7 @@ struct mt_device {#define MT_CLS_3M 0x0101 #define MT_CLS_CYPRESS 0x0102 #define MT_CLS_EGALAX 0x0103 +#define MT_CLS_EGALAX_SERIAL 0x0104 #define MT_DEFAULT_MAXCONTACT 10@@ -174,6 +175,12 @@ static struct mt_class mt_classes[] = {.sn_move = 4096, .sn_pressure = 32, }, + { .name = MT_CLS_EGALAX_SERIAL, + .quirks = MT_QUIRK_SLOT_IS_CONTACTID | + MT_QUIRK_ALWAYS_VALID, + .sn_move = 4096, + .sn_pressure = 32, + }, { } };@@ -705,7 +712,7 @@ static const struct hid_device_id mt_devices[] = {{ .driver_data = MT_CLS_EGALAX, HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7302) }, - { .driver_data = MT_CLS_EGALAX, + { .driver_data = MT_CLS_EGALAX_SERIAL, HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001) }, -- 1.7.4.4
-- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html