Re: [PATCH] Input: psmouse - change log messages from psmouse.c to psmouse

Hi Daniel,

On Fri, Oct 07, 2011 at 06:07:28PM +0800, Daniel Kurtz wrote:

Hi Dmitry,

On Fri, Oct 7, 2011 at 2:39 PM, Dmitry Torokhov

quoted

-static int synaptics_validate_byte(unsigned char packet[], int idx, unsigned char pkt_type)

Why pass idx if we already have psmouse?

static int synaptics_validate_byte(struct psmouse *psmouse, unsigned
char pkt_type)

We are checking specific byte... If you look down we call the function
in a cycle over entire packet to fugure whether we need to do strict or
relaxed checking.

...

quoted

       if (synaptics_query_hardware(psmouse)) {
-               printk(KERN_ERR "Unable to query Synaptics hardware.\n");
+               psmouse_err(psmouse, "Unable to query Synaptics hardware.\n");

               psmouse_err(psmouse, "unable to query device.\n");

We can get rid of some more redundant "Synaptics"...

Good idea, I'll update the messages.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html