Thread (4 messages) 4 messages, 2 authors, 2011-10-18

Re: [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init

From: Ricardo Ribalda Delgado <hidden>
Date: 2011-10-18 17:10:43
Also in: lkml

Ok,

 I remove that patch and fix it for the new cmr3000 driver


    Thanks!

On Tue, Oct 18, 2011 at 19:03, Dmitry Torokhov
[off-list ref] wrote:
On Tuesday, October 18, 2011 09:57:24 AM Ricardo Ribalda Delgado wrote:
quoted
Hello Dmitry

 You are right, and also could be a good idea to init the irq, only
after the input device has been registered. Dont you think so?
Input core is constructed in such way that it is safe to call
input_report_*() and input_event() on properly allocated input device,
even if it has not been registered yet, the events will simply be
dropped.

So no, it is not necessary and doing so is quite often complicates
error handling in probe() routines.

Thanks.

--
Dmitry


-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help