Re: [PATCH] Input: atmel_mxt_ts - Use snprintf for sysfs attribute show method

From
Nick Dyer <hidden>
Date
2011-10-06 10:08:35
Also in
lkml
Reply to
Daniel Kurtz, 2011-09-15
Hi Daniel-

Just to introduce myself, I'm working for Atmel in UK on the atmel_mxt_ts driver.

Daniel Kurtz wrote:
Sysfs attribute show methods are always passed a buffer of length
PAGE_SIZE.  To keep from overwriting this buffer and causing havoc,
use snprintf() to guarantee we never write more than the buffer can
hold.

In addition, at least for my touchscreen, the number and size of
objects was far too big to fit in a single 4K page.  Therefore, this
patch also trims some redundant framing text to leave more room for
actual data.
Yes, I'd noticed this problem as well. I was planning to address it by splitting up the file, but your patch looks like a good solution for now.

I've tested it successfully on several chips.

Acked-by: Nick Dyer <redacted>

-- 
Nick Dyer
Software Engineer, ITDev  Ltd

Hardware and Software Development Consultancy

Email:   nick.dyer@itdev.co.uk
Website: http://www.itdev.co.uk
Thread (7 messages) 7 messages, 5 authors, last reply 2011-10-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help