Re: [PATCH] input: lis3dh: Add driver for lis3dh accelerometer

On 09/24/11 07:09, Dmitry Torokhov wrote:

On Tue, Sep 20, 2011 at 11:26:00AM +0100, Jonathan Cameron wrote:

quoted

quoted

+
+enum lis3dh_interrupt_mode {
+	LIS3DH_OR_COMBINATION = 0x00,
+	LIS3DH_6D_MOVEMENT = 0x40,
+	LIS3DH_AND_COMBINATION = 0x80,
+	LIS3DH_6D_POSITION = 0xc0,
+};

Enums seem silly when you don't have at least
vaguely consecutive values.  Why not just use defines?

Actually enums are not quite silly as compiler can warn you if you
handle all possible cases in a switch() statement.

Thanks.

Fair point, if that is happening.  Right now none of this stack of enums
seems to even be used and so I'm not sure which ones would make sense in
a switch (or if they should be there at all).