Re: [patch] Input: potential info leak in uiput_ff_upload_to_user()

On Fri, Sep 23, 2011 at 09:22:40AM +0300, Dan Carpenter wrote:

Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.

The issue here is that struct uinput_ff_upload_compat has a hole in
it.

struct uinput_ff_upload_compat {
        int                        request_id;           /*     0     4 */
        int                        retval;               /*     4     4 */
        struct ff_effect_compat    effect;               /*     8     0 */

        /* XXX 44 bytes hole, try to pack */

        struct ff_effect_compat    old;                  /*    52     0 */

44 bytes... doubtful...

Thanks.

-- 
Dmitry