On Fri, Sep 9, 2011 at 3:41 PM, Dmitry Torokhov
[off-list ref] wrote:

On Tue, Sep 06, 2011 at 06:56:46PM -0500, chris@cnpbagwell.com wrote:

quoted

From: Chris Bagwell <redacted>

Bamboo's with Product ID's > 0xD4 return values unrelated to pressure
in touch 1 pressure field.  They also report touch 2's X/Y values
shifted down 1 byte (where pressure was).  This results in jumpy
1 finger touch and totally invalid 2nd finger data.

For touch detection, switch to a Touch Present single bit that
all versions of Bamboo support.

For touch 2 offset, calculate offset based on a bit that is set
different between the two packet layouts.

Since touch pressure reports were removed from driver, there was
no need to be reading pressure any more.

Signed-off-by: Chris Bagwell <redacted>
Reviewed-by: Ping Cheng <redacted>

Applied, thanks Chris.

I'm sorry, Dmitry, but I messed up this version #2 of patch.  Can you
please revert or hand fix?

+               touch = touch && wacom->shared->stylus_in_proximity;

Somewhere along the line, I lost a "!" on that stylus_in_proximity
check.  So this v2 patch breaks touch support.

If you revert, I am planning on submitting 2 or 3 new wacom clean up
patches in next week.  I can resend with that batch.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html