[PATCH] hidraw : free list for all error in hidraw_open
From: Amit Nagal <hidden>
Date: 2011-09-02 05:37:25
Hi , In function hidraw_open (linux-3.0.3/drivers/hid/hidraw.c ) , struct hidraw_list *list should be freed for all error conditions . Following is patch enclosed for the same : Signed-off-by: Amit Nagal <redacted> --- diff -uprN linux-3.0.3/drivers/hid/hidraw.c.orig linux-3.0.3/drivers/hid/hidraw.c
--- linux-3.0.3/drivers/hid/hidraw.c.orig 2011-09-0113:23:19.000000000 -0400
+++ linux-3.0.3/drivers/hid/hidraw.c 2011-09-02 06:25:08.000000000 -0400@@ -259,7 +259,6 @@ static int hidraw_open(struct inode *ino mutex_lock(&minors_lock); if (!hidraw_table[minor]) { - kfree(list); err = -ENODEV; goto out_unlock; }
@@ -285,6 +284,8 @@ static int hidraw_open(struct inode *ino out_unlock: mutex_unlock(&minors_lock); out: + if (err < 0) + kfree(list); return err; } --