V Vinicius Costa Gomes #
Message details and related content
Hi Antonio, On 16:14 Thu 25 Aug, Antonio Ospite wrote:
On Fri, 19 Aug 2011 21:08:54 +0200 Antonio Ospite [off-list ref] wrote:quoted
On Fri, 19 Aug 2011 10:58:02 +0200 Antonio Ospite [off-list ref] wrote:quoted
On Thu, 18 Aug 2011 16:18:57 -0700 Marcel Holtmann [off-list ref] wrote:[...]quoted
quoted
I rather have the Sixaxis plugin being an external plugin only then. So you are not allowed to make this builtin.Marcel, I guess that an _external_ plugin in BlueZ context is one which is not embedded in the bluetoothd binary but rather distributed as a shared object, isn't it? Are there examples of such a plugin in bluez tree I can copy from?OK, I think I've got it, it is external-dummy, this is how I did it: --- Makefile.am | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)diff --git a/Makefile.am b/Makefile.am index 4bcff4d..ff33bf0 100644 --- a/Makefile.am +++ b/Makefile.am@@ -230,8 +230,10 @@ builtin_sources += thermometer/main.c \ endif if SIXAXISPLUGIN -builtin_modules += sixaxis -builtin_sources += plugins/sixaxis.c +plugin_LTLIBRARIES += plugins/sixaxis.la +plugins_sixaxis_la_SOURCES = plugins/sixaxis.c +plugins_sixaxis_la_LDFLAGS = -module -avoid-version -no-undefined @UDEV_LIBS@
The problem is the visibility of the symbols, src/bluetooth.ver defines which symbols should[1] be visible to plugins. Every plugin should only depend on those methods from the "core". If we want to keep the sixaxis plugin external we need to make the symbols it need visible, but I wonder if that is right solution. [1] Seems that with builtin plugins that visibility enforcement doesn't work, right?
Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Cheers, -- Vinicius