Re: [PATCH] HID: magicmouse: ignore 'ivalid report id' while switching modes

On 08/23/2011 01:53 AM, Jiri Kosina wrote:

On Thu, 18 Aug 2011, Jaikumar Ganesh wrote:

quoted

I also tracked down two Apple magic trackpads - both with the same
Bluetooth version.
One which needs this patch (as it returns an invalid report id) and
the other which doesn't need this patch.
Both use the same device id.

Gotta love hardware vendors indeed.

So how about the patch below?



From: Jiri Kosina <redacted>
Subject: [PATCH] HID: magicmouse: ignore 'ivalid report id' while switching modes, v2

                                    spelling: ^

This is basically a more generic respin of 23746a6 ("HID: magicmouse: ignore
'ivalid report id' while switching modes") which got reverted later by
c3a492.

It turns out that on some configurations, this is actually still the case
and we are not able to detect in runtime.

The device reponds with 'invalid report id' when feature report switching it
into multitouch mode is sent to it.

This has been silently ignored before 0825411ade ("HID: bt: Wait for ACK
on Sent Reports"), but since this commit, it propagates -EIO from the _raw
callback .

So let the driver ignore -EIO as response to 0xd7,0x01 report, as that's
how the device reacts in normal mode.

Sad, but following reality.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=35022

Reported-by: Chase Douglas <redacted>
Reported-by: Jaikumar Ganesh <redacted>
Tested-by: Chase Douglas <redacted>
Signed-off-by: Jiri Kosina <redacted>

Looks good to me. I tested it and it fixed things here.

Thanks!

-- Chase