Re: [Device-drivers-devel] [PATCH 3/4] Input: ad714x - use DMA-safe buffers for spi_write()
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-08-22 00:46:27
ike Frysinger [off-list ref] wrote:
On Sun, Aug 21, 2011 at 16:09, Dmitry Torokhov wrote:quoted
spi_write() requires use of DMA-safe (cacheline aligned) buffers. Also use the same buffers when reading data since to avoid extra locking and potential memory allocation in spi_write_then_read().seems like there's a whole lot of style changes unrelated to spi and dma ... more so than the actual dma/spi change.
Hmm, I tried to control myself so (aside of return -> error) renames there shouldn't be many style changes... The diff looks big because we are passing ad714x instead of ad714x->dev to the read/write methods. -- Dmitry