Re: [PATCH BlueZ 3/4] Link to udev only when needed
From: Marcel Holtmann <marcel@holtmann.org>
Date: 2011-08-18 23:19:27
Also in:
linux-bluetooth
Possibly related (same subject, not in this thread)
- 2011-08-26 · Re: [PATCH BlueZ 3/4] Link to udev only when needed · Antonio Ospite <hidden>
- 2011-08-25 · Re: [PATCH BlueZ 3/4] Link to udev only when needed · Vinicius Costa Gomes <hidden>
- 2011-08-25 · Re: [PATCH BlueZ 3/4] Link to udev only when needed · Antonio Ospite <hidden>
- 2011-08-19 · Re: [PATCH BlueZ 3/4] Link to udev only when needed · Antonio Ospite <hidden>
- 2011-08-05 · [PATCH BlueZ 3/4] Link to udev only when needed · Antonio Ospite <hidden>
Hi Antonio,
quoted
Don't link bluetoothd to udev unconditionally, but only when it is needed. For now bluetoothd needs to be linked to udev only when the sixaxis plugin is enabled.Any comment on this change? If it looks OK I'll fold it in v5. Thanks, Antonioquoted
--- Makefile.am | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)diff --git a/Makefile.am b/Makefile.am index dbe0170..219ca0f 100644 --- a/Makefile.am +++ b/Makefile.am@@ -288,7 +288,11 @@ src_bluetoothd_SOURCES = $(gdbus_sources) $(builtin_sources) \ src/event.h src/event.c \ src/oob.h src/oob.c src/eir.h src/eir.c src_bluetoothd_LDADD = lib/libbluetooth.la @GLIB_LIBS@ @DBUS_LIBS@ \ - @CAPNG_LIBS@ @UDEV_LIBS@ -ldl -lrt + @CAPNG_LIBS@ -ldl -lrt +if SIXAXISPLUGIN +src_bluetoothd_LDADD += @UDEV_LIBS@ +endif + src_bluetoothd_LDFLAGS = -Wl,--export-dynamic \ -Wl,--version-script=$(srcdir)/src/bluetooth.ver
I rather have the Sixaxis plugin being an external plugin only then. So you are not allowed to make this builtin. Regards Marcel