Re: [PATCH 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support

Hi Javier,

On Sat, Aug 20, 2011 at 12:01:50AM -0400, Javier Martinez Canillas wrote:

Cypress TrueTouch(tm) Standard Product controllers are found in
a wide range of embedded devices. This driver add support for a
variety of TTSP controllers.

The driver is composed of a core driver that process the data sent by
the contacts and a set of bus specific interface modules. This patch
adds the base core TTSP driver.

The original author of the driver is Kevin McNeely [off-list ref]

Since the hardware is capable of tracking identifiable contacts and the
original driver used multi-touch protocol type A (stateless), multi-touch
protocol type B (stateful) support was added by Javier Martinez Canillas.

Still reading through the patches, but have one question:

+
+	ts->irq = gpio_to_irq(ts->platform_data->irq_gpio);
+	if (ts->irq <= 0) {
+		dev_dbg(ts->dev, "%s: Error, failed to allocate irq\n",
+			__func__);
+			goto error_init;
+	}

Why do we need to get gpio/irq from platform data instead of having
board code set up controllers appropriately and use IRQ either from I2C
client structure or from SPI?

Thanks.

-- 
Dmitry