RE: [PATCH v1] Input: tegra-kbc - fix computation of polling time

Thanks Dmitry and Thierry.

Regards
Rakesh

-----Original Message-----
From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
Sent: Saturday, July 30, 2011 12:02 PM
To: Thierry Reding
Cc: Rakesh Iyer; rydberg@euromail.se; olof@lixom.net; Allen Martin; linux-
kernel@vger.kernel.org; linux-input@vger.kernel.org
Subject: Re: [PATCH v1] Input: tegra-kbc - fix computation of polling time

On Sat, Jul 30, 2011 at 12:41:01PM +0200, Thierry Reding wrote:

quoted

* riyer@nvidia.com wrote:

quoted

From: Rakesh Iyer <redacted>

Fix a constant definition and computation of polling time.

Signed-off-by: Rakesh Iyer <redacted>
---
 drivers/input/keyboard/tegra-kbc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index da3828f..263f6fc 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c

@@ -37,7 +37,7 @@
 #define KBC_ROW_SCAN_DLY	5

 /* KBC uses a 32KHz clock so a cycle = 1/32Khz */
-#define KBC_CYCLE_USEC	32
+#define KBC_CYCLE_MS	32

 /* KBC Registers */

@@ -647,7 +647,7 @@ static int __devinit tegra_kbc_probe(struct platform_device

*pdev)

quoted

quoted

 	debounce_cnt = min(pdata->debounce_cnt, KBC_MAX_DEBOUNCE_CNT);
 	scan_time_rows = (KBC_ROW_SCAN_TIME + debounce_cnt) * num_rows;
 	kbc->repoll_dly = KBC_ROW_SCAN_DLY + scan_time_rows + pdata->repeat_cnt;
-	kbc->repoll_dly = ((kbc->repoll_dly * KBC_CYCLE_USEC) + 999) / 1000;
+	kbc->repoll_dly = (kbc->repoll_dly + KBC_CYCLE_MS - 1) / KBC_CYCLE_MS;

You might want to consider using DIV_ROUND_UP for this.

Indeed. Adjusted locally and applied.

Thanks.

--
Dmitry