[PATCH] Input: gpio_keys - Return proper error code

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE5505d

2 messages, 2 authors, 2011-07-30 · open the first message on its own page

[PATCH] Input: gpio_keys - Return proper error code

From: Tobias Klauser <tklauser@distanz.ch>
Date: 2011-07-27 09:20:05

Return -ENOMEM if kzalloc fails in gpio_keys_get_devtree_pdata.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/input/keyboard/gpio_keys.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index ce281d1..67df91a 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -483,7 +483,7 @@ static int gpio_keys_get_devtree_pdata(struct device *dev,
 
 	buttons = kzalloc(pdata->nbuttons * (sizeof *buttons), GFP_KERNEL);
 	if (!buttons)
-		return -ENODEV;
+		return -ENOMEM;
 
 	pp = NULL;
 	i = 0;
-- 
1.7.5.4

Re: [PATCH] Input: gpio_keys - Return proper error code

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-07-30 19:08:34

On Wed, Jul 27, 2011 at 11:10:47AM +0200, Tobias Klauser wrote:
Return -ENOMEM if kzalloc fails in gpio_keys_get_devtree_pdata.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied, thanks Tobias.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help