Re: [PATCH v5 1/2] Input: gpio_keys.c: Added support for device-tree platform data

On Mon, 4 Jul 2011 10:28:06 -0700
Dmitry Torokhov [off-list ref] wrote:

On Mon, Jul 04, 2011 at 08:56:51AM +0200, David Jander wrote:

quoted

On Mon, 04 Jul 2011 10:52:55 +0400
Dmitry Torokhov [off-list ref] wrote:

quoted

David Jander [off-list ref] wrote:

quoted

On Thu, 23 Jun 2011 11:01:22 -0700
Dmitry Torokhov [off-list ref] wrote:

quoted

On Thu, Jun 23, 2011 at 07:25:37AM -0600, Grant Likely wrote:

quoted

On Thu, Jun 23, 2011 at 6:39 AM, Alan Cox

[off-list ref] wrote:

quoted

quoted

quoted

quoted

quoted

+       - gpios: OF devcie-tree gpio specificatin.
+       - label: Descriptive name of the key.
+       - linux,code: Keycode to emit.

The fact that this is the Linux internal keycode definitions

still

quoted

quoted

quoted

quoted

makes me nervous.  Is there no existing standard for keycodes

emitted

quoted

quoted

quoted

quoted

by keyboard devices?

There is but no standard lookup table. For Intel MID we do a

translation

quoted

quoted

quoted

between Linux key names in the firmware and keycodes but there

isn't a

quoted

quoted

quoted

generic helper for it.

I suppose the Linux keycodes are exported out to userspace, and are
therefore an ABI which will not change.  Okay.

Right, keycodes form ABI that will not change.

Another option would be to use codes from HID usage tables but then
they would have to be translated to Linux ones.

Dmitry, will you accept this patch also?
Until now, part 2/2 is in your tree, thanks for that, but I'd like to
know if
this part (1/2) will also be accepted?

Yes, I will since there was no more discussion about hid codes and I do
believe that using linux definitions is fine.

Ok, thanks.

Noticed that we leaked dynamically allocated button data in case when
gpio_keys_probe() fails.

Eeek. Sorry. Thanks for pointing out.

Also removed changelog from copyright notice
(we have SCM for it) and got rid of a warning in case of !CONFIG_OF.

Ah, ok. I was just imitating others here, but this is a good point ;-)

Could you please tell me if the patch below still work for you?

Yes, it seems to work fine.

Best regards,

-- 
David Jander
Protonic Holland.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html