Re: [PATCH v5] input: Initial support for Kionix KXTJ9 accelerometer

On Wed, Jun 29, 2011 at 01:39:41PM +0100, Jonathan Cameron wrote:

On 06/28/11 20:12, chris.hudson.comp.eng@gmail.com wrote:

quoted

+static int kxtj9_input_open(struct input_dev *input)
+{
+	struct kxtj9_data *tj9 = input_get_drvdata(input);
+
+	return kxtj9_enable(tj9);

return kxtj9_enable(input_get_drvdata(input));

Actually I prefer limiting use of void pointers. If kxtj9_enable()
changes to take something other than "struct kxtj9_data *" then original
will issue a warning while the proposed form will happily accept it.

Thanks.

-- 
Dmitry