Re: [PATCH v4 3/3] Input: gpio_keys.c: Enable use with non-local GPIO chips.

On Wed, Jun 22, 2011 at 5:38 AM, Mark Brown
[off-list ref] wrote:

On Wed, Jun 22, 2011 at 12:00:52AM -0700, Dmitry Torokhov wrote:

quoted

On Wed, Jun 22, 2011 at 12:02:42AM +0100, Mark Brown wrote:

quoted

On Tue, Jun 21, 2011 at 01:48:05PM -0700, Dmitry Torokhov wrote:

quoted

quoted

quoted

Can the initcall stuff be kept out of mainline? I'd expect

quoted

quoted

The init order stuff is in mainline already, you're far too late to the
party here.

quoted

For some drivers it might be already in mainline, it does not matter
that we should continue adding more.

It's not just a few drivers, there's entire subsystems that are doing
this.

quoted

quoted

Keeping things in board trees is exactly the sort of thing we want to
avoid people doing.  That just means people do all sorts of stuff that
wouldn't be acceptable upstream, either out of ignorance or through
knowing that only their systems have to work with what they're doing,
and just don't bother working upstream at all half the time making life
miserable for pretty much everyone.

quoted

So you are saying that we should accept such crap directly into
mainline?

Pretty much, yes.  In code terms it's not really invasive and it doesn't
have any real impact on other systems so it's the sort of thing we can
carry without too much pain.  Pragmatically it's not unreasonable.

+1

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html