Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata
From: Jean Delvare <hidden>
Date: 2011-06-21 08:55:32
Also in:
linux-i2c
Possibly related (same subject, not in this thread)
- 2011-06-20 · [PATCH] input/keyboard: Remove obsolete cleanup for clientdata · Wolfram Sang <hidden>
On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote:
A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang <redacted> Cc: Dmitry Torokhov <redacted> Cc: Bo Shen <redacted> Cc: Axel Lin <redacted>
Acked-by: Jean Delvare <redacted>
quoted hunk
--- This is more a cleanup than a bugfix. Still, would be happy to have this obsolete programming style largely removed in 3.0 if possible. drivers/input/keyboard/qt1070.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c index ca7b891..b21bf5b 100644 --- a/drivers/input/keyboard/qt1070.c +++ b/drivers/input/keyboard/qt1070.c@@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client) input_unregister_device(data->input); kfree(data); - i2c_set_clientdata(client, NULL); - return 0; }
-- Jean Delvare