Re: [RFC 05/12] HID: wiimote: Synchronize wiimote input and hid event handling

On Thu, Jun 16, 2011 at 12:18 PM, Oliver Neukum [off-list ref] wrote:

Am Donnerstag, 16. Juni 2011, 11:20:18 schrieb Jiri Kosina:

quoted

quoted

Here an smp_wmb()
It is redundant because input_register_device takes a spinlock which
implies a barrier, but you'll make the automated checking tools happier.

Yeah, spinlock implies SMP barrier implicitly.

I don't think adding barriers just to make some buggy automatic checker
happy is worth it.

Fine by me as long as the problem is understood.

Does that mean that I can omit the smp_rmb(), too? I do not like
relying on input_register_device to use a spinlock. It makes reading
the code hard, so I added both barriers. Should I remove them again or
keep them?

Thank you for reviewing. I have fixed all your concerns. I will resend
the patches if there are no more comments on the code as [PATCH] in
few days.

Regards
David