Re: [PATCH] INPUT: gpio_keys.c: Added OF support and enabled use with I2C GPIO expanders

On Thu, 2 Jun 2011 15:18:29 +0530
Shubhrajyoti Datta [off-list ref] wrote:

On Wed, Jun 1, 2011 at 2:37 PM, [off-list ref] wrote:

quoted

From: David Jander <redacted>

You may want to briefly explain the changes.

<Snip>

quoted

+
       input = input_allocate_device();
       if (!ddata || !input) {
               dev_err(dev, "failed to allocate state\n");

@@ -465,12 +585,12 @@ static int __devinit gpio_keys_probe(struct

platform_device *pdev)
       ddata->disable = pdata->disable;
       mutex_init(&ddata->disable_lock);

-       platform_set_drvdata(pdev, ddata);
+       dev_set_drvdata(dev, ddata);
       input_set_drvdata(input, ddata);

-       input->name = pdev->name;
+       input->name = "GPIO_keyboard";

Why this change?

Good question.... somehow it isn't necessary anymore, and it was quite wrong
anyway. Thanks for pointing out, must have slipped over this....

Best regards,

-- 
David Jander
Protonic Holland.