Re: [PATCH 03/12] Input: synaptics - fix minimum reported ABS_TOOL_WIDTH
From: Chris Bagwell <hidden>
Date: 2011-06-29 13:28:29
Also in:
lkml
On Wed, Jun 29, 2011 at 12:07 AM, [off-list ref] wrote:
From: Daniel Kurtz <redacted> Synaptics touchpads report a 'w' value in each data report. For touchpads that support palm detection, when there is a single finger on the pad, the 'w' value reports its width in the range 4 to 15. Thus, the minimum valid width is 4.
FYI: I had debated on this as well. When driver was first modified to report min/max width, the min width of zero was chosen because when not touching the pad a value of zero is forced by driver to user. So the range is 0, 4-15.
quoted hunk ↗ jump to hunk
Note: Other values of 'w' are used to report special conditions: w=0: 2 fingers are on the pad w=1: 3 or more fingers are on the pad w=2: the packet contains "Advanced Gesture Mode" data. Signed-off-by: Daniel Kurtz <redacted> --- drivers/input/mouse/synaptics.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index f6d0c04..a4b7801 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c@@ -706,7 +706,7 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv)} if (SYN_CAP_PALMDETECT(priv->capabilities)) - input_set_abs_params(dev, ABS_TOOL_WIDTH, 0, 15, 0, 0); + input_set_abs_params(dev, ABS_TOOL_WIDTH, 4, 15, 0, 0); __set_bit(EV_KEY, dev->evbit); __set_bit(BTN_TOUCH, dev->keybit); -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html