quoted

What locks this SMBUS transaction against others

True! I will look over the locking for the next version.

I have a suspicion the two drivers are distant relatives actually - the
bugs look similar !

quoted

quoted

+static int bma150_set_range(struct i2c_client *client, unsigned char range)
+{
+	int ret;
+	unsigned char data;
+
+	if (range > BMA150_RANGE_8G)
+		return -EINVAL;

This should be actual values not a register range

It is an actual value. See chapter 3.1.2 in the BMA150 datasheet where the
acceleration range values are defined.

It should specify the units and be in meaningful ones not register values
(I got moaned at for that in my submission too!)

I will send an updated version of the driver once I've fixed it!

Cool - I really don't care btw which driver we end up with a mix of both,
I just need it to work on our platform too.

Dunno where Dmitry has gone - has he vanished ?