Thread (2 messages) 2 messages, 2 authors, 2011-05-02

Re: ad714x driver help and possible bug

From: Jean-Francois Dagenais <hidden>
Date: 2011-05-02 20:43:15
Also in: lkml

Possibly related (same subject, not in this thread)

On Apr 29, 2011, at 10:58, Michael Hennerich wrote:
On 04/29/2011 04:52 PM, Michael Hennerich wrote:
quoted
On 04/29/2011 11:55 AM, Jonathan Cameron wrote:
quoted
Cc'd input, and analog devices driver list...

On 04/28/11 19:17, Jean-Francois Dagenais wrote:

quoted
I also had to change the request_threaded_irq flags to specify
IRQF_ONESHOT so the kernel keeps the interrupt masked while we are
running ad714x_interrupt_thread(). Otherwise we were getting storms
of interrupts each time only one was requested. I am wondering if
this should be pulled back to the mainline kernel?

Thanks for pointers and clues!
I assume this is due to the fact that the interrupt on the host is
level sensitive.
In this case you need to use the IRQF_ONESHOT flag.
The unmodified driver requests the IRQ as IRQF_TRIGGER_FALLING, so
this is not necessary.
I succeeded in making the ISR occur only once per real interrupt, the problem I explained earlier remains.
quoted
To my knowledge we regularly test the driver with the sliders, wheels
and buttons found on the
official evaluation board, and so far we haven't found oddities.
For an example platform file see: arch/blackfin/mach-bf537/boards/stamp.c
From top of my head I don't know whether we're testing with the SPI or
I2C interface.

http://wiki.analog.com/software/driver/linux/ad714x
-- 

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help