Re: [PATCH 2/2 v3] Input: atmel_mxt_ts - Make CHG line high after the interrupts are enabled

Make the CHG line (interrupt line) go high after the interrupts have been enabled to make sure
we don't miss the falling edge.

Signed-off-by: Iiro Valkonen <redacted>
---
v3: Change the locations where this is done to ensure correct operation at FW update,
   and to get rid of some error handling

 drivers/input/touchscreen/atmel_mxt_ts.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 4012436..5f09f57 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c

@@ -804,10 +804,6 @@ static int mxt_initialize(struct mxt_data *data)

       if (error)
               return error;

-       error = mxt_make_highchg(data);
-       if (error)
-               return error;
-
       mxt_handle_pdata(data);

       /* Backup to memory */

@@ -981,6 +977,10 @@ static ssize_t mxt_update_fw_store(struct device *dev,

       enable_irq(data->irq);

+       error = mxt_make_highchg(data);
+       if (error)
+               return error;
+
       return count;
 }

@@ -1090,6 +1090,10 @@ static int __devinit mxt_probe(struct i2c_client *client,

               goto err_free_object;
       }

+       error = mxt_make_highchg(data);
+       if (error)
+               goto err_free_irq;
+
       error = input_register_device(input_dev);
       if (error)
               goto err_free_irq;
--
1.7.0.4