Thread (5 messages) 5 messages, 3 authors, 2011-04-22

Re: [PATCH 1/2] HID: hid-multitouch: refactor last_field_index

From: Jiri Kosina <hidden>
Date: 2011-04-22 09:55:38
Also in: lkml

On Thu, 21 Apr 2011, Henrik Rydberg wrote:
quoted
the current implementation requires the devices to report
HID_DG_CONTACTCOUNT to set the last_field_index value.
However, devices reporting in serial mode (DWAV and PenMount)
do not send this field.
Other devices (3M) add other fields in the reports descriptor
that are not multitouch related at the end, thus the need to
add a special case in the default case when handling events.

A first work around has been set up but with PenMount devices,
we have reached the limit.

The idea is to calculate the last_field_index by relying only on
multitouch fields the device send. This allows us to remove
the handling of non-multitouch events in hid-multitouch, and
guarantee that the function mt_emit_event is always called.

Signed-off-by: Benjamin Tissoires <redacted>
---
Reviewed-and-tested-by: Henrik Rydberg [off-list ref]
Applied, thanks guys.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help