Thread (23 messages) 23 messages, 2 authors, 2011-03-16

Re: [PATCH 09/17] Input: tsc2005 - rework driver initialization code

flat view

From: Aaro Koskinen <hidden>
Date: 2011-03-16 15:14:24

Hi,
-	r = input_register_device(ts->idev);
-	if (r) {
-		dev_err(&ts->spi->dev, "input_register_device(): %d\n", r);
-		goto err2;
+	ts = kzalloc(sizeof(*ts), GFP_KERNEL);
+	input_dev = input_allocate_device();
+	if (!ts || !input_dev) {
+		error = -ENOMEM;
+		goto err_free_mem;
	}
ts->idev is never initialized, so input_register_device() will crash.

A.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help