Re: [PATCH v3] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework.
flat view
From: Benjamin Tissoires <hidden>
Date: 2011-03-11 06:53:05
Hi Richard, I'm really sorry, but it's a NACK for me: what ever Henrik said, I do not want to have numerical constants throughout the code. It would be the open door to many others. The reason we have "mt_class" is to regroup each per-device parameters in it. So there is no need to introduce those constants everywhere. Cheers, Benjamin On Fri, Mar 11, 2011 at 07:02, Richard Nauber [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Hi, Except for a missing comma, Henriks patch works fine for me and I would be glad to have it submitted. So feel free to add my SIGNED-OFF-BY. (Or should I repost the patch?) Greetings and thanks to all, Richard--- snip --- diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 57575ff..ee01e65 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c@@ -131,7 +131,7 @@ struct mt_class mt_classes[] = {{ .name = MT_CLS_EGALAX, .quirks = MT_QUIRK_SLOT_IS_CONTACTID | MT_QUIRK_VALID_IS_INRANGE | - MT_QUIRK_EGALAX_XYZ_FIXUP + MT_QUIRK_EGALAX_XYZ_FIXUP, .maxcontacts = 2, .sn_move = 4096, .sn_pressure = 32, -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html