Thread (2 messages) 2 messages, 2 authors, 2011-03-31

[PATCH resend] input/spear-keyboard fix: return IRQ_NONE if (status reg & DATA_AVAIL)

From: Rajeev Kumar <hidden>
Date: 2011-03-28 11:59:06
Also in: linux-arm-kernel
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

We should return IRQ_NONE from interrupt handler in case data is not
avail for keyboard

Signed-off-by: Rajeev Kumar <redacted>
---
 drivers/input/keyboard/spear-keyboard.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index f18dc67..c6ab1df 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -70,7 +70,7 @@ static irqreturn_t spear_kbd_interrupt(int irq, void *dev_id)
 	u8 sts, val;
 
 	sts = readb(kbd->io_base + STATUS_REG);
-	if (sts & DATA_AVAIL)
+	if (!(sts & DATA_AVAIL))
 		return IRQ_NONE;
 
 	if (kbd->last_key != KEY_RESERVED) {
-- 
1.6.0.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help